Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 'Comparing LightFM with HybridSVD.ipynb' #17

Open
rodfloripa opened this issue Mar 16, 2022 · 3 comments
Open

Notebook 'Comparing LightFM with HybridSVD.ipynb' #17

rodfloripa opened this issue Mar 16, 2022 · 3 comments

Comments

@rodfloripa
Copy link

I tried to run https://github.com/evfro/polara/blob/master/examples/Comparing%20LightFM%20with%20HybridSVD.ipynb, had
to change the variable catch=None to catch=(RuntimeWarning,). It doesn't run if you don't make this change.

@rodfloripa
Copy link
Author

Commas are missing here:
all_scores = {
'SVD (best)': svd.evaluate()
'LightFM (best)': evaluate_lightfm(lfm)
f'HybridSVD (rank {hsvd.rank})': hsvd.evaluate()
}

Corrected
all_scores = {
'SVD (best)': svd.evaluate(),
'LightFM (best)': evaluate_lightfm(lfm),
f'HybridSVD (rank {hsvd.rank})': hsvd.evaluate()
}

@rodfloripa
Copy link
Author

Replace :
trials_df = (study.trials_dataframe().loc[:, ['value', 'params', 'user_attrs']].rename(columns={'': target_metric}))
To:
trials_df = study.trials_dataframe().loc[:, ['value', 'params_rank', 'user_attrs_metrics','user_attrs_epochs']].rename(columns={'': target_metric})

@evfro
Copy link
Owner

evfro commented Mar 26, 2022

Hi! Thanks for reporting!

I'll have a look. There's a long-time-delayed update in my internal develop branch, I'll include the necessary modifications in the forthcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants