Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue when trying to "show" many images in a loop #82

Open
Ariandr opened this issue Dec 17, 2018 · 1 comment
Open

Performance issue when trying to "show" many images in a loop #82

Ariandr opened this issue Dec 17, 2018 · 1 comment

Comments

@Ariandr
Copy link

Ariandr commented Dec 17, 2018

  • Library setup method: CocoaPods
  • Version of the library. 'moa', '> 10.0' 'Auk', '> 9.0'
  • Xcode version. 10.1
  • OS version. 12.1.1

There is an issue when I try to show many images at once. In my case there are 57 images (urls). I realized that fact because of the Time Profiler. There was a noticeable lag during scrolling (1-1.5 sec) and I decided to investigate.

self.bannerImageView.auk.removeAll()
for urlStr in bannerURLs { // 57 elements in the array
    self.bannerImageView.auk.show(url: urlStr)
}

Is it possible to create a method which will be able to receive not one image at a time (or url), but an array of them and therefore do less work under the hood? It's just my thoughts and I don't really know if it's possible to implement, but in my opinion it will be a useful feature of the library.

@evgenyneu
Copy link
Owner

Hi @Ariandr, that's a good idea. Feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants