Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateMnemonic does not validate a checksum #44

Closed
steida opened this issue Oct 22, 2022 · 1 comment
Closed

validateMnemonic does not validate a checksum #44

steida opened this issue Oct 22, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@steida
Copy link
Contributor

steida commented Oct 22, 2022

We are using a fork of https://github.com/bitcoinjs/bip39, because the original library is not tree-shakeable.

bitcoinjs/bip39#169 (comment)

We have to port validateMnemonic implementation as well.

@steida steida added the good first issue Good for newcomers label Oct 22, 2022
@steida
Copy link
Contributor Author

steida commented Feb 7, 2023

Done

@steida steida closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant