Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_diamond.c #1017

Closed
wants to merge 1 commit into from
Closed

Conversation

Imran-imtiaz48
Copy link

I made several improvements to enhance readability and consistency. First, I removed unnecessary comments, such as clang-format and TEST_IGNORE() lines, which made all tests active by default. I also ensured consistent formatting across all functions for better clarity and flow. Additionally, I consolidated the RUN_TEST statements, eliminating line breaks to make the main function more concise. These changes make the code easier to maintain, cleaner, and ready for execution without needing further adjustments to run the tests.

I made several improvements to enhance readability and consistency. First, I removed unnecessary comments, such as clang-format and TEST_IGNORE() lines, which made all tests active by default. I also ensured consistent formatting across all functions for better clarity and flow. Additionally, I consolidated the RUN_TEST statements, eliminating line breaks to make the main function more concise. These changes make the code easier to maintain, cleaner, and ready for execution without needing further adjustments to run the tests.
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ryanplusplus
Copy link
Member

Most of what you fixed is a result of the auto formatter. The reason that we have the tests disabled by default is to encourage a TDD-like approach to solving the exercises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants