Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient test cases for "Resistor Color Expert" #3795

Open
xanni opened this issue Oct 21, 2024 · 4 comments
Open

Insufficient test cases for "Resistor Color Expert" #3795

xanni opened this issue Oct 21, 2024 · 4 comments

Comments

@xanni
Copy link
Contributor

xanni commented Oct 21, 2024

I submitted code that passed all the existing tests but failed to correctly handle some actual resistor values in use in the E48 (2% tolerance) and larger series. There are currently no tests for 5-band resistors where the second band is black, which my earlier iteration handled wrongly.
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@BethanyG BethanyG reopened this Oct 22, 2024
@BethanyG
Copy link
Member

Linking forum discussion.

Happy to accept suggested test cases and/or PR. 😄

@xanni
Copy link
Contributor Author

xanni commented Oct 23, 2024

PR created: #3797

@BethanyG
Copy link
Member

I am going to keep this open until we figure out if we want 3-band cases. I am leaning towards "no", but want to discuss it a bit on the forum first. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BethanyG @xanni