Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version being shared between fetcher revision and derivation #34

Open
expipiplus1 opened this issue Oct 26, 2020 · 1 comment
Open

Comments

@expipiplus1
Copy link
Owner

like https://github.com/nixos/nixpkgs/blob/master/pkgs/tools/misc/tmux/default.nix#L24-L33

stdenv.mkDerivation rec {
  pname = "tmux";
  version = "3.1b";

  outputs = [ "out" "man" ];

  src = fetchFromGitHub {
    owner = "tmux";
    repo = "tmux";
    rev = version;
    sha256 = "0jvyq4r691bn0wsr8i6c0q0lzss25vm9nx8sv3fhw9cs63ncq04y";
  };

This should update the version expression and not the rev one.

@expipiplus1
Copy link
Owner Author

actually in general if anything to be updated is a variable then that variable should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant