Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching a file from a git repo as an asset #12181

Closed

Conversation

danieldk
Copy link
Contributor

Description

Our Git fetcher code assumed that the asset to be copied was a directory. Support files as well and add tests to check both the file and directory cases.

Fixes explosion/weasel#66.

Types of change

Bugfix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Our Git fetcher code assumed that the asset to be copied was a
directory. Support files as well and add tests to check both the file
and directory cases.

Fixes #12168.
@danieldk danieldk added bug Bugs and behaviour differing from documentation projects spaCy projects and project templates labels Jan 25, 2023
@adrianeboyd
Copy link
Contributor

The same git problem cropped up in #12155.

@adrianeboyd
Copy link
Contributor

See: #12155 (comment)

@adrianeboyd
Copy link
Contributor

This would need to be moved to weasel.

jeffrey12cali added a commit to jeffrey12cali/weasel that referenced this pull request Mar 19, 2024
svlandeg pushed a commit to explosion/weasel that referenced this pull request Mar 25, 2024
* Porting explosion/spaCy#12181 solution into weasel

* Running isort on changed files

* Replacing TemporaryDirectory with already implemented make_tempdir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation projects spaCy projects and project templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using a file in a git repository as an asset in spacy projects config
2 participants