[eas-cli] VCS Context Fields to replace helper functions

[Josh-McFarlin]

Why

Context fields make it easier for eas-cli commands to express their dependencies.

How

Created a new context field for getVcsClient and ensureRepoExistsAsync and replaced usages of their original helper function calls with references to EAS Command contexts.

Test Plan

Run yarn test locally and all tests pass on CI.

[linear]

ENG-8958 Context field git command eas-cli

The task it to convert getVcsClient and ensureRepoExistsAsync into a command context. Talk to wschurman about how to do this.

[github-actions]

Size Change: +1.75 kB (0%)

Total Size: 42.6 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	42.6 MB	+1.75 kB (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Merging #2086 (f751c75) into main (5ed155e) will decrease coverage by 0.03%.
The diff coverage is 33.83%.

@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
- Coverage   54.07%   54.04%   -0.03%     
==========================================
  Files         508      509       +1     
  Lines       18674    18658      -16     
  Branches     3934     3933       -1     
==========================================
- Hits        10097    10081      -16     
  Misses       7886     7886              
  Partials      691      691              

Files	Coverage Δ
packages/eas-cli/src/build/ios/build.ts	35.56% <ø> (ø)
packages/eas-cli/src/commandUtils/EasCommand.ts	96.78% <100.00%> (+0.06%)	⬆️
.../src/commandUtils/context/VcsClientContextField.ts	100.00% <100.00%> (ø)
packages/eas-cli/src/commands/branch/create.ts	45.17% <ø> (ø)
packages/eas-cli/src/commands/build/cancel.ts	51.32% <ø> (ø)
packages/eas-cli/src/commands/build/index.ts	20.54% <ø> (ø)
packages/eas-cli/src/commands/build/internal.ts	63.16% <ø> (ø)
packages/eas-cli/src/commands/build/list.ts	33.34% <ø> (ø)
packages/eas-cli/src/commands/build/resign.ts	30.00% <ø> (ø)
packages/eas-cli/src/commands/build/run.ts	21.22% <ø> (ø)
... and 53 more

[Josh-McFarlin]

/changelog-entry chore Move getVcsClient and ensureRepoExistsAsync into command context. (#2086 by @Josh-McFarlin)

[wschurman]

This looks great and is a great step towards injecting more dependencies! See inline comment about a potential follow-up PR.

[wschurman]

Ideally, in a follow-up PR, we could get rid of this function so that future command authors aren't tempted to just call this and instead are led to the "pit of success" by only being able to access this via a context. Of course, to do this will require more mocking in tests, so that's why I suggest doing this in a separate PR after this one.

For context (no pun intended), one of the original reasons for having context fields was to prevent command authors from calling getProjectAsync directly without calling a method to set it up. Now, all accesses to the project run the same code that ensures the project is set up correctly.

[Josh-McFarlin]

/changelog-entry chore Move getVcsClient and ensureRepoExistsAsync into command context. (#2086 by @Josh-McFarlin)

[github-actions]

✅ Thank you for adding the changelog entry!