Detect when compression middleware is installed? #72
Comments
|
No, there isn't a good way to know if this module is active or not (yet?), but perhaps you may just not want your SSE responses compressed at all? If that is the case, then your code can always set the header Let me know if you really do want your responses to be compressed, and I'm sure we can think of a good way to provide the indication to your code :) |
|
I'm unsure of how much impact gzip will have on SSE, since we're explicitly telling it to flush before having basically any data to work with. If gzip can somehow keep optimizing data as it comes in even though the "initial chunk" is sent, then it might actually be able to provide a pretty significant improvement. Any idea if this is the case or not? |
Yes, this is the case. Your initial chunks between So it sounds like the take away may be to determine if the dictionary is actually shared between the chunks or not, so it can be better evaluated if the compression is actually helping or hurting the stream (I believe it does help). In parallel, we can probably think of a good way to indicate if the response is getting compressed in a unique way that is obvious and doesn't conflict too much (darn Node.js taking |
Supports use such as:
```javascript
// Not going to write again for a while. If compression middleware is
// installed let's tell it to flush what we've got through to the client.
if (res.flushCompression) {
res.flushCompression();
}
```
Currently the `res` object has a `flush` method regardless of whether
compression middleware is installed. The built-in `flush` method issues a
noisy deprecation warning. This patch provides an alias for the `flush`
method to allow detection of the compression middleware's `flush`.
This addresses expressjs#72.
Supports use such as:
```javascript
// Not going to write again for a while. If compression middleware is
// installed let's tell it to flush what we've got through to the client.
if (res.flushCompression) {
res.flushCompression();
}
```
Currently the `res` object has a `flush` method regardless of whether
compression middleware is installed. The built-in `flush` method issues a
noisy deprecation warning. This patch provides an alias for the `flush`
method to allow detection of the compression middleware's `flush`.
This addresses expressjs#72.
|
#74 would solve this for me. Any feedback on that, @dougwilson ? |
I am the author of a library called sse-channel, which implements server-sent events (SSE). For this to work in an efficient and fast manner, I need to be able to call
flushon responses that pass through this compression middleware.Currently I'm just checking for the presence of a
flushmethod on the response and calling that, but since node has this method, it's causing me some issues. Is there a way I can detect whether the flush method is from this middleware, or if the compression middleware is applied to the response, somehow?The text was updated successfully, but these errors were encountered: