-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question / Feature Request] CORS-RFC1918 Support #236
Comments
Yea, an option to enable this can certainly be added. I'm not sure what you mean by auto magically, though. Can you elaborate on what you are picturing with that? |
@dougwilson what @NoelDavies means is that you can automatically enable and add the required headers if you detect private IP like I'm personally against that as it defies the purpose of having these headers in the first place. But we can have some property like As I understand in the preflight request the client needs to use the header |
Chrome 98 seems to have started to add and require Access-Control-Request-Private-Network header. After disabling chrome://flags/#block-insecure-private-network-requests , Chrome still adds and requires the header. For future visitors, you can do:
But I hope to see some flag in cors package. |
Chrome Beta version 102, started the experiment again and the preflight requests are sent with For future readers, disabling both the following flags are required, in case you wanna disable requesting the headers from the Chrome browser for now. chrome://flags/#block-insecure-private-network-requests |
I created PR #274 for this. About the "maybe auto-magically?": user agents should only send the |
Is your feature request related to a problem? Please describe.
I've not seen this mentioned before (apologies if it has come up).
Chrome will soon implement this and block any public to private requests (public domain to 127.0.0.1).
See https://chromestatus.com/feature/5436853517811712
Describe the solution you'd like
Update the cors package to easily set the new CORS header (maybe auto-magically?)
https://wicg.github.io/private-network-access/#headers
Describe alternatives you've considered
I could host a centralized server, but I'd rather not do this for my users.
Additional context
Chrome's current warning message
This now appears in chrome:
[Deprecation] The website requested a subresource from a network that it could only access because of its users' privileged network position. These requests expose non-public devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage. To mitigate these risks, Chrome deprecates requests to non-public subresources when initiated from non-secure contexts, and will start blocking them in Chrome 92 (July 2021). See https://chromestatus.com/feature/5436853517811712 for more details.
(Sidenote - spoke to to the socket.io devs and they pointed me to you guys - socketio/socket.io#3929)
The text was updated successfully, but these errors were encountered: