Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masking #43

Open
ouvoun opened this issue Aug 11, 2023 · 2 comments
Open

Masking #43

ouvoun opened this issue Aug 11, 2023 · 2 comments

Comments

@ouvoun
Copy link

ouvoun commented Aug 11, 2023 •
edited
Loading

Hey folks!

Thanks for the nice library. I was testing the feasibility of using it in our production app, and noticed that it doesn't seem to support masking, unless I'm missing something.

Looking in SVGNode, I see that it includes a mask parameter is passed, but not actually used. I do see that clipping seems to be done in applyNodeAttributes(model:) What level of effort would be involved with getting masking working?
@ouvoun ouvoun changed the title Clipping & masking masking Aug 11, 2023
@ouvoun ouvoun changed the title masking Masking Aug 11, 2023
@f3dm76
Copy link
Collaborator

f3dm76 commented Aug 12, 2023

Hey @ouvoun, this is a big feature, and unfortunately we don't have resources right now. You are most welcome to commit a PR. Have a nice day

@martijnvanwelie
Copy link

Also would love to see masking support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@f3dm76 @martijnvanwelie @ouvoun