Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: Property 'TextEncoder' doesn't exist #5

Closed
mattjbrill opened this issue Sep 24, 2024 · 5 comments
Closed

ReferenceError: Property 'TextEncoder' doesn't exist #5

mattjbrill opened this issue Sep 24, 2024 · 5 comments

Comments

@mattjbrill
Copy link

Greetings,

FYI, the qrcode dependency has an issue in 1.5.4, which is causing this ReferenceError: Property 'TextEncoder' doesn't exist error (soldair/node-qrcode#373 (comment)). They do not currently have a fix available. Resolving the dependency to 1.5.3 (instead of ^1.5.3) works around this issue for now.

Thanks for everything you're doing! Appreciate it!

@exzos28
Copy link
Owner

exzos28 commented Sep 24, 2024

I've release 1.4.0 with 1.5.4 qrcode.
You are welcome.

@exzos28 exzos28 closed this as completed Sep 24, 2024
@exzos28 exzos28 reopened this Sep 24, 2024
@exzos28
Copy link
Owner

exzos28 commented Sep 24, 2024

Maybe I didn't understand you completely. Does qrcode 1.5.4 have this problem?

@mattjbrill
Copy link
Author

Oh wow you're fast! Haha!

My apologies. Yes, qrcode 1.5.4 has the problem. 1.5.3 does not have the problem. Your package.json uses "qrcode": "^1.5.0", and the caret (^) means it will grab whatever version is compatible with the one you've listed. So you'll need to use "qrcode": "1.5.3" instead of "qrcode": "^1.5.0".

Sorry, I should have just put up a pr :(

@exzos28
Copy link
Owner

exzos28 commented Sep 24, 2024

🌚
Yeah, I know what the caret means. But there is a lock file in the project that saves the version at the time of installation. Anyway, thanks for the information.

What about qrcode... I have a plan to rewrite or find different solution for this package. But that's just a plan. Haha.

P.S I've released the patch for this mistake.

@exzos28 exzos28 closed this as completed Sep 24, 2024
@mattjbrill
Copy link
Author

My bad. I'm used to working with juniors. Haha!

Awesome thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants