Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in rust versions and pipelines #1335

Closed
tessus opened this issue Jan 18, 2025 · 1 comment
Closed

inconsistency in rust versions and pipelines #1335

tessus opened this issue Jan 18, 2025 · 1 comment

Comments

@tessus
Copy link

tessus commented Jan 18, 2025

It seems that pipelines are using different MSRV. The project uses rust 1.74, but the BSD pipelines seems to use the latest version of rust.

This makes creating a PR a mess, because some pipelines fail due to clippy issues. So if 2 people create separate PRs at the same time, there will be the same clippy fixes in those PRs.
Until the main branch has fixed all clippy issues for the latest rust version.

I'm currently in the process of creating a PR, but I know a few pipelines will fail, even though the clippy fixes are already in #1327.

The options:

  • make all pipelines use the same rust version
  • run clippy for the project with the latest rust version and fix the main branch
@tessus tessus changed the title inconsistentcy in rust versions and pipelines inconsistency in rust versions and pipelines Jan 18, 2025
@tessus
Copy link
Author

tessus commented Jan 18, 2025

Please ignore. My bad. The pipelines failed for another reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant