Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion Coding Standard #1

Open
agungsugiarto opened this issue Sep 15, 2020 · 1 comment
Open

Suggestion Coding Standard #1

agungsugiarto opened this issue Sep 15, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@agungsugiarto
Copy link

Is your feature request related to a problem? Please describe.
I am happy to see OAuth 2.0 Server by phpleague come to CodeIgniter4, this is nice to start using oauth2, but before i am jump to this i will recomendating to refactor lot of code between source code and documentation following psr2 or maybe follow coding standard by CodeIgniter4, but i will be prefer to using follow psr2.

Describe the solution you'd like
PHP CodeSniffer is nice tool to refactor code.

Describe alternatives you've considered

Additional context

@ezralazuardy ezralazuardy self-assigned this Sep 16, 2020
@ezralazuardy ezralazuardy added the enhancement New feature or request label Sep 16, 2020
@ezralazuardy
Copy link
Owner

thanks for reporting. yes, heimdall still need the implementation of PSR 2 (coding style standard), but currently I don't have time to do that, it'll would be great if you can open a new pull request though, because this library is at it's early stage and need more development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants