From d19b5cbe486f7aa84cf8705a214567a9d07ab5fe Mon Sep 17 00:00:00 2001 From: Carlos Segarra Date: Tue, 20 Jun 2023 16:59:01 +0000 Subject: [PATCH 1/3] gha: try to make nng panic every time in gha --- .github/workflows/tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index aeef320ad..46f5f4101 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -129,6 +129,9 @@ jobs: run: ./bin/inv_wrapper.sh dev.cmake --clean --build=Debug --sanitiser ${{ matrix.sanitiser }} - name: "Build tests" run: ./bin/inv_wrapper.sh dev.cc faabric_tests + # Try to make the NNG panics consistent in GHA + - name: "Run one conflicting test in repeat" + run: ./bin/inv_wrapper.sh tests --test-case "Test starting and stopping the function migration thread" --repeats 20 - name: "Run tests" run: ./bin/inv_wrapper.sh tests From 07836ed74924a7d8c572fef1310935c5f40b0071 Mon Sep 17 00:00:00 2001 From: Carlos Segarra Date: Tue, 20 Jun 2023 17:30:12 +0000 Subject: [PATCH 2/3] gha: use single quotes instead? --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 46f5f4101..a95b075dc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -131,7 +131,7 @@ jobs: run: ./bin/inv_wrapper.sh dev.cc faabric_tests # Try to make the NNG panics consistent in GHA - name: "Run one conflicting test in repeat" - run: ./bin/inv_wrapper.sh tests --test-case "Test starting and stopping the function migration thread" --repeats 20 + run: ./bin/inv_wrapper.sh tests --test-case "Test\ starting\ and\ stopping\ the\ function\ migration\ thread" --repeats 20 - name: "Run tests" run: ./bin/inv_wrapper.sh tests From 26249de6d1e9c3994c3997179949e7070be0e5c0 Mon Sep 17 00:00:00 2001 From: Carlos Segarra Date: Wed, 21 Jun 2023 11:02:14 +0000 Subject: [PATCH 3/3] trying things --- .github/workflows/tests.yml | 2 +- src/transport/MessageEndpoint.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a95b075dc..72768eac1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -131,7 +131,7 @@ jobs: run: ./bin/inv_wrapper.sh dev.cc faabric_tests # Try to make the NNG panics consistent in GHA - name: "Run one conflicting test in repeat" - run: ./bin/inv_wrapper.sh tests --test-case "Test\ starting\ and\ stopping\ the\ function\ migration\ thread" --repeats 20 + run: /build/faabric/static/bin/faabric_tests "Test starting and stopping the function migration thread" - name: "Run tests" run: ./bin/inv_wrapper.sh tests diff --git a/src/transport/MessageEndpoint.cpp b/src/transport/MessageEndpoint.cpp index 77cece848..18391783c 100644 --- a/src/transport/MessageEndpoint.cpp +++ b/src/transport/MessageEndpoint.cpp @@ -279,11 +279,13 @@ void MessageEndpoint::sendMessage(uint8_t header, nng_aio_set_msg(aio, msg); + /* if (context.has_value()) { nng_ctx_send(*context, aio); } else { + */ nng_send_aio(socket, aio); - } + // } nng_aio_wait(aio); int ec = nng_aio_result(aio);