[TS] Support [<Mangle>]
on interface
#3943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3863
@ncave I was looking into fixing #3863 and manage to fix that specific case however, if the members as an argument different than
unit
then it doesn't work because that member should me mangled.The difficulty is
Mangle
name computation happens duringFSharp2Fable
transformation, but for interfaces we don't do it.How should we approach this problem? Should we try to add
Mangle
information for interface too which means making a changes toFable.AST
or can we recompute theMangle
/HashSuffix
using FableEntity instead of FSharpEntity?