Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JustifyContent should be made type safe just like AlignItems #150

Open
MangelMaxime opened this issue Apr 1, 2019 · 2 comments
Open

JustifyContent should be made type safe just like AlignItems #150

MangelMaxime opened this issue Apr 1, 2019 · 2 comments

Comments

@MangelMaxime
Copy link
Member

No description provided.

@jannesiera
Copy link
Contributor

It seems like a lot of CSSProps are typed by an obj or a string where they could benefit from more type safety. Is there a reason why they're not typed by a DU, for example?

@MangelMaxime
Copy link
Member Author

It's because of Fable.React is one of the older libraries and at the time, we wanted to have a thin layer on top of React. So using obj make it easy to do that because the user can write center, 2px, calc(100vh - 3em), etc.

We are also a small team of core maintainer and can't do all the evolution ourself :)

Because we accepted making some of the properties type-safe, we would accept a PR converting more properties to be type-safe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants