Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Elmish commands in ReactiveCom #62

Open
EdouardM opened this issue Feb 26, 2018 · 0 comments
Open

Implement Elmish commands in ReactiveCom #62

EdouardM opened this issue Feb 26, 2018 · 0 comments

Comments

@EdouardM
Copy link

Hello @alfonsogarciacaro ,

I think it would be nice to implement Elmish commands in Fable.Helpers.React.ReactiveCom to make it fully compliant with Fable.Elmish.

I have played with this over the week-end and I am going to submit a PR to show what I came up with.

** Warning ** : This includes a new depedency to Fable.Elmish in the projet. If you want me to rewrite Elmish.Cmd<'Msg> I can do it. But I thought over time the codebase of the 2 project may not stay in sync.

Feel free to reply with suggestions.

Regards;
Edouard
EdouardM added a commit to EdouardM/fable-react that referenced this issue Feb 26, 2018
@EdouardM
Implement Elmish Command in ReactiveCom fable-compiler#62
8c2c454 
- Added a dependency to Fabl.Elmish
- Rewrite of the update loop of ReactiveCom
- Added an Error handler to ReactiveCom
@EdouardM EdouardM mentioned this issue Feb 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Elmish Commads in ReactiveCom EdouardM/fable-react
1 participant
@EdouardM