Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/Export/build.sh out of sync with ncave's fsharp "export" branch #177

Open
davedawkins opened this issue Jan 26, 2023 · 4 comments
Open

Comments

@davedawkins
Copy link

src/Export/build.sh contains these lines

cd ../$NCAVE_FSHARP_REPO
git checkout export
dotnet build -c Release src/buildtools/buildtools.proj
dotnet build -c Release src/fsharp/FSharp.Compiler.Service

However @ncave 's branch (https://github.com/ncave/fsharp/tree/export) no longer contains these paths.

@davedawkins
Copy link
Author

For now, I think I can change the checkout to

git checkout export_2020-10-01

For reference, I'm trying to rebuild Sutil's REPL. I hear talk of a newer version of the REPL that allows configuration of additional modules, it's possible this might help me when it comes along.

@ncave
Copy link
Contributor

ncave commented Jan 26, 2023

@davedawkins Sure, going back to a previous stable release makes sense, if you don't want to fix paths.

There is always churn in dotnet/fsharp so grabbing latest will sometimes be a bit different, but I try to keep the build script in the repo working (/fcs/build.sh).

At the same time, you don't always need to build the .NET metadata binaries export (unless you want to), you can just fetch them from the Fable repo (/src/fable-metadata/lib), unless you need to export them from a specific version of .NET.

Here is the current version of the build script:

dotnet build -c Release buildtools
dotnet build -c Release src/Compiler
dotnet run -c Release --project fcs/fcs-export

Again, this is just to export .NET metadata binaries, there is a separate fork for building FCS for Fable, and another for building FCS for Fable REPL.

@davedawkins
Copy link
Author

Thank you - it was just a new Fable.Repl.Lib.dll that I needed to build and export.

@ncave
Copy link
Contributor

ncave commented Mar 18, 2023

@davedawkins Can this be closed, or is it still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants