Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled successfully toasts are stacking #46

Open
ncave opened this issue Sep 26, 2018 · 3 comments
Open

Compiled successfully toasts are stacking #46

ncave opened this issue Sep 26, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@ncave
Copy link
Contributor

ncave commented Sep 26, 2018

Compiled successfully toasts are stacking high when you compile several times in a row.
Not a breaking issue, more of an enhancement, perhaps compile notifications can go to the console pane, now that it's there (or to the problems pane, if we rename that to compile output).

@MangelMaxime MangelMaxime added the enhancement New feature or request label Sep 26, 2018
@MangelMaxime
Copy link
Member

Indeed the reason being they are not toast like we have on our mobile phone. On mobile, you can have only one toast displayed at the time.

They are more like a notification system.

We can't have it in the problems panel. The problems panel is dedicated to the state of the editor nor the last compilation.

If we clear the console panel history when compilation has been a success as suggested in #43. Then we can probably add it to the console panel. And keep the toast for compilation failure.

@ncave
Copy link
Contributor Author

ncave commented Sep 26, 2018

@MangelMaxime Technically you can stack failure upon failure too, I do it all the time.

@MangelMaxime
Copy link
Member

Then this is probably a new feature to add in Thoth.Elmish.Toast.

The feature I have in mind is to allow user attach a "group" to a Toast and say. I only want one Toast of this group displayed at a time.
If there is already a toast of the same group in the stack then it will be removed and the new one is added. This feature also needs to add transition/animation support so people can see the old toast being removed when the new one is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants