Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to the list of methods that do not get parentheses #383

Open
bibstha opened this issue Dec 5, 2022 · 0 comments · May be fixed by #410
Open

Add test to the list of methods that do not get parentheses #383

bibstha opened this issue Dec 5, 2022 · 0 comments · May be fixed by #410

Comments

@bibstha
Copy link
Contributor

bibstha commented Dec 5, 2022

  • Ruby version: 2.7.2
  • Rubyfmt git sha: 9ed05fc

Input file

test "this is a test in rails" do
  assert(true)
end

Rubyfmt's output

test("this is a test in rails") do
  assert(true)
end

This breaks because

There was an old issue: #54 that mentions a bunch of keywords that shouldn't have () after the method call. However test has not been included in the list in rubyfmt.

test is like describe or it keywords that Rails uses to define test cases and is widely used. Therefore this should be added too.

Screenshot 2022-12-05 at 10 17 44 PM

@reese reese linked a pull request Feb 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant