Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support style in Expandable #97

Open
stoyle opened this issue Apr 20, 2022 · 0 comments
Open

Support style in Expandable #97

stoyle opened this issue Apr 20, 2022 · 0 comments

Comments

@stoyle
Copy link
Contributor

stoyle commented Apr 20, 2022

The props of Expandable says it support a style prop, however I cannot see it is actually added anywhere. Also checked the sources, but I might of course be wrong.

It would help us quite a bit to handle custom styling. However, the way our component was designed we need to target the inner button and span, and that may not what this style prop was intended for?

Anyways, our styling targets a surrounding div, targeted by css modules, and we have overriden styles the following way. If there is a way to prevent this, that would of course be awesome.

.expandArea div button {
    display: flex;
    align-items: center;
}

.expandArea div button span {
    font-weight: normal;
    margin-right: 18px;
    hyphens: manual;
    overflow-wrap: break-word;
    display: inline-block;
}

.expandArea div button:focus,
.expandArea div button:hover {
    text-decoration: none;
}

Will be happy to provide a PR if you give me a direction for how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant