Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

WIP render branch list picker #1166

Closed
wants to merge 1 commit into from

Conversation

edewit
Copy link
Member

@edewit edewit commented Mar 29, 2019

There are still 2 issues with this:

  1. The branch list endpoint seems to return [] in all cases
  2. Do we need to call the "buildImage suggest" again after selecting a branch?

fixes: #1160

@quintesse
Copy link
Contributor

  1. has been fixed
  2. the user still has to click a button (or hit ENTER) to start the analysis, right?

I think the ideal solution would be to have the branch prefilled with "master" and only get the actual list of branch names the moment the user clicks the dropdown to see the list. In 99% of the cases people will just use master and don't need anything else, so perhaps we shouldn't waste any time waiting for a result that will be used only in 1% of the cases.

Something like this perhaps?:

image

@ia3andy
Copy link
Contributor

ia3andy commented Apr 3, 2019

@edewit I am closing the PR until you start working on this feature again ;-)

@ia3andy ia3andy closed this Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Branch" edit box to import card
3 participants