This repository has been archived by the owner on May 29, 2024. It is now read-only.
feature: add OpenShiftCluster#getOauthUrl #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewit
force-pushed
the
oauth_openshift
branch
from
e213be1
to
4fdb181
Compare
edewit
force-pushed
the
oauth_openshift
branch
from
4fdb181
to
dd41668
Compare
gastaldi
commented
Sep 2, 2019
| try { | ||
| const r = await this.httpService.get<any>(this.config.launcherURL, '/services/openshift/clusters', requestConfig); | ||
| const r = await this.httpService.get<any>(this.config.launcherURL, '/services/openshift/clusters/all', requestConfig); |
There was a problem hiding this comment.
You need to query /clusters here. The fact that it is returning 0 clusters is because the original starter clusters are gone
There was a problem hiding this comment.
if I query clusters I will get an error as I'm not logged in right?
|
closed in in favour of #979 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972