Sundrio bump to 0.101.3 causes problems with cert-manager generated code (getClass) #5564
Comments
6 tasks
manusa
changed the title
|
For some reason, the compiled Ingress class is getting generated with the proper sanitized fields but it includes an extra-setter: @JsonInclude(Include.NON_NULL)
@JsonPropertyOrder({"class", "ingressTemplate", "name", "podTemplate", "serviceType"})
@JsonDeserialize(
using = JsonDeserializer.None.class
)
public class Ingress implements KubernetesResource {
//...
@JsonProperty("class")
@JsonPropertyDescription("The ingress class to use when creating Ingress resources to solve ACME challenges that use this challenge solver. Only one of 'class' or 'name' may be specified.")
@JsonSetter(
nulls = Nulls.SKIP
)
private String _class;
//...
public Ingress() {
}
public String get_class() {
return this._class;
}
public void set_class(String _class) {
this._class = _class;
}
//...
@JsonProperty("class")
@JsonSetter(
nulls = Nulls.SKIP
)
public void setClass(String _class) {
this._class = _class;
}
}I'm trying to reproduce the behavior in a test (Approval), but I'm not able to. In the test, the extra-setter is not created. |
|
OK, I think that the root-cause for this is the usage of the: annotations that now work properly (probably after sundrio/sundrio#439) |
|
So the problem lies on Sundrio and is specific to this configuration combination. The following list summarizes the problem:
|
|
I think we can remove those lombok annotations now. In #5384, we introduced getter/setter creation. Trying this as a fix now. |
11 tasks
manusa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Relates to
When bumping the sundrio dependency to the latest release that overcomes the Type inference problem, the cert-manager integration test no longer compiles:
I'm going to disable this test to bump the Sunrio depenency, but should be fixed and reenabled before releasing 6.9.2.
/cc @andreaTP
The text was updated successfully, but these errors were encountered: