Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions #20

Open
2 tasks
jackherizsmith opened this issue Jun 12, 2020 · 1 comment
Open
2 tasks

Questions #20

jackherizsmith opened this issue Jun 12, 2020 · 1 comment
Labels
code review question Further information is requested

Comments

@jackherizsmith
Copy link

  • Love how you've coded the Q@A section - could this be abstracted even more? i.e. import an object with question answer key/value pairs to avoid hard-coding them? I suppose only worthwhile if you anticipate having to change or expand these as the app grows

  • React Axe looks cool! Would you recommend?
@jackherizsmith jackherizsmith added question Further information is requested code review labels Jun 12, 2020
@jamesj-0
Copy link
Contributor

Yeah React Axe has been great, we've had a few accessibility issues with colours mainly so its been useful to see where they are being highlighted. We are guilty of not fixing the errors when they crop up as its been a fast paced build

Also on this note, you should use Eslint! I noticed you'd opted not to use it, It can be quite picky so you can customise its strictness. Would recommend using some configuration of it so everyone in the team is writing consistent code. Just a quick read but expands on this further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code review question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesj-0 @jackherizsmith