You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general it looks like you're nailing it! I'm well impressed, and it's great that you're utilising Material UI, Prop-types and styled-components and overall I think it's looking really tidy 🚀 💅 💥 ( + tests! 💯 🥇 )
A couple of general thoughts/improvements :
I'd try to be consistent with your function declarations - there are places where you're using arrow functions and places where you're not. I'd try and stick with arrow functions where possible.
Be consistent with your styled components too, you have a couple of separate styles files (apart from the global styles) but most of your styled components are in the same file as your React components. I'd make a decision on which way you want to do it and stick with it.
Style constants: it's really good that you have your colours as constants that you can access. You could extend this to add your font styles and even spacing etc. if you have time to tidy it up.
The text was updated successfully, but these errors were encountered:
In general it looks like you're nailing it! I'm well impressed, and it's great that you're utilising Material UI, Prop-types and styled-components and overall I think it's looking really tidy 🚀 💅 💥 ( + tests! 💯 🥇 )
A couple of general thoughts/improvements :
I'd try to be consistent with your function declarations - there are places where you're using arrow functions and places where you're not. I'd try and stick with arrow functions where possible.
Be consistent with your styled components too, you have a couple of separate styles files (apart from the global styles) but most of your styled components are in the same file as your React components. I'd make a decision on which way you want to do it and stick with it.
Style constants: it's really good that you have your colours as constants that you can access. You could extend this to add your font styles and even spacing etc. if you have time to tidy it up.
The text was updated successfully, but these errors were encountered: