Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code review #24

Open
mkatenolan opened this issue Jun 15, 2020 · 0 comments
Open

General code review #24

mkatenolan opened this issue Jun 15, 2020 · 0 comments

Comments

@mkatenolan
Copy link

In general it looks like you're nailing it! I'm well impressed, and it's great that you're utilising Material UI, Prop-types and styled-components and overall I think it's looking really tidy 🚀 💅 💥 ( + tests! 💯 🥇 )

A couple of general thoughts/improvements :

  • I'd try to be consistent with your function declarations - there are places where you're using arrow functions and places where you're not. I'd try and stick with arrow functions where possible.

  • Be consistent with your styled components too, you have a couple of separate styles files (apart from the global styles) but most of your styled components are in the same file as your React components. I'd make a decision on which way you want to do it and stick with it.

  • Style constants: it's really good that you have your colours as constants that you can access. You could extend this to add your font styles and even spacing etc. if you have time to tidy it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant