Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider some abstraction #36

Open
yeo-yeo opened this issue Apr 24, 2020 · 0 comments
Open

consider some abstraction #36

yeo-yeo opened this issue Apr 24, 2020 · 0 comments
Assignees
@itsina96 @jackherizsmith
Labels
code review suggestion

Comments

@yeo-yeo
Copy link

yeo-yeo commented Apr 24, 2020

Home.js / createDogElement() gets the job done but it is not super DRY. You are frequently re-writing the lines of code to create element, add properties, set innerHTML.

Consider doing something like the example we saw on Tuesday in here:
https://github.com/oliverjam/learn-dom-rendering

From the same workshop, have a think about the difference between using append and appendChild
itsina96 added a commit that referenced this issue Apr 24, 2020
@itsina96 @jackherizsmith
refactor createPage function
d802e88 
Relates #36

Co-authored-by: jackherizsmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsina96 itsina96

@jackherizsmith jackherizsmith

Labels
code review suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yeo-yeo @itsina96 @jackherizsmith