Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov badge #135

Open
jackherizsmith opened this issue May 29, 2020 · 2 comments
Open

Codecov badge #135

jackherizsmith opened this issue May 29, 2020 · 2 comments
Labels

Comments

@jackherizsmith
Copy link
Collaborator

We're so close 😵

how do we take it from unknown to our staggering 60% recorded on Codecov.io?

@jackherizsmith jackherizsmith added help wanted Extra attention is needed code review 2 labels May 29, 2020
@glrta
Copy link

glrta commented May 29, 2020

The badge seems to be fine now.

Looking at the dashboard in codecov.io it seems the report in the backend is only scoped to the files that are being tested, rather than the whole project (you are testing really well the files that you are testing=) well done!). You might be able to include in your Jest config a 'collectCoverageFrom'.

@glrta
Copy link

glrta commented May 30, 2020

Jack, I added this below on my local (api json) and it worked to scope codecov to all files, excluding coverage and node_modules:

"collectCoverageFrom": [
    "**/*.js",
    "!node_modules/**",
    "!coverage/**"
  ]

I also notice that both of your test scripts run in watch mode. This could be the problem when setting up Travis, as the test never cease to run and won't go to the next task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants