Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laurie Code Review 🎍 #128

Open
sgroi-l opened this issue Nov 29, 2023 · 0 comments
Open

Laurie Code Review 🎍 #128

sgroi-l opened this issue Nov 29, 2023 · 0 comments

Comments

@sgroi-l
Copy link

sgroi-l commented Nov 29, 2023

I think your app is beautiful and you should be so proud! Here are some extremely minor suggestions.

Could be more a touch more responsive.

image

Some of your buttons are a bit iffy/take ages to work. I think its cos you have links inside buttons like this.

<Button className="w-full p-16 bg-white border-4 border-solid border-primaryBlue rounded-full">
   <Link href="/upload" className="text-primaryBlue text-4xl">
             Sell
   </Link>
</Button>

If you put the buttons inside links this should fix this issue. ie

<Link href="/search" >
          <Button>
              Buy
          </Button>
</Link>

Your logo doesn't redirect to home, it currently redirects to the page that you are on.

Maybe change

<Link href="#">

to

   <Link href="/">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant