From dd101d39dfaed216ddf1b7fdfcf4bee80c0f0909 Mon Sep 17 00:00:00 2001
From: David Crosby <dcrosby@meta.com>
Date: Tue, 25 Jul 2023 14:38:28 -0700
Subject: [PATCH] Change TargetChefVersion to 16.18.0

Summary:
Activates the following lints which, while enabled in cookstyle.yml, weren't running due to the unmet

- Chef/Modernize/LibarchiveFileResource
- Chef/Deprecations/MacosUserdefaultsGlobalProperty
- Chef/Deprecations/PoiseArchiveUsage
- Chef/Modernize/PowershellScriptExpandArchive
- Chef/Modernize/SevenZipArchiveResource
- Chef/Modernize/WindowsRegistryUAC
- Chef/Modernize/WindowsZipfileUsage
- Chef/Modernize/ZipfileResource

Chef/Deprecations/LogResourceNotifications will need to be ratcheted in.

Differential Revision: D47613067

fbshipit-source-id: c7c7ca4bff79c2862a1dd1e8a4f8859f3ee989f0
---
 .cookstyle.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.cookstyle.yml b/.cookstyle.yml
index e6e2717f..d6519331 100644
--- a/.cookstyle.yml
+++ b/.cookstyle.yml
@@ -5,7 +5,7 @@ AllCops:
   # new cops and make upgrades easier (ie not dealing with a bunch of noise
   # each Cookstyle update)
   DisabledByDefault: true
-  TargetChefVersion: 14.15.6
+  TargetChefVersion: 16.18.0
 
 Chef/Correctness/BlockGuardWithOnlyString:
   Enabled: true
@@ -137,7 +137,7 @@ Chef/Deprecations/LibrarianChefSpec:
 Chef/Deprecations/LocaleDeprecatedLcAllProperty:
   Enabled: true
 Chef/Deprecations/LogResourceNotifications:
-  Enabled: true
+  Enabled: false # TODO(T158851402) ratchet back in
 Chef/Deprecations/MacosUserdefaultsGlobalProperty:
   Enabled: true
 Chef/Deprecations/NamePropertyWithDefaultValue: