You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to both the docs and the logs, '_clowntown_override_file_method' allows you to add additional restrictions to when override files take effect, but if it's not defined, then they always take effect.
Turns out, this isn't true, we always return false. This is a simple bug, but fixing it it probably requires a slow rollout to FB so I haven't sent a PR.
Docs:
For additional safety, you can define a check method in
`node['fb_storage']['_clowntown_override_file_method']`
that will be invoked whenever override files are evaluated.
Actual code where we say we're ignore the method, but then returnf alse.
defoverride_file_applies?(verb,fname,quiet=false)ifFile.exist?(fname)base_msg="fb_storage: System has #{fname} file present"ifnode['fb_storage']['_clowntown_override_file_method']
...
endunlessquietChef::Log.warn("#{base_msg} but the override check method is not defined, " +
'therefore we are ignoring it.',)endreturnfalse# this should be `true`endreturnfalseend
The text was updated successfully, but these errors were encountered:
According to both the docs and the logs, '_clowntown_override_file_method' allows you to add additional restrictions to when override files take effect, but if it's not defined, then they always take effect.
Turns out, this isn't true, we always return false. This is a simple bug, but fixing it it probably requires a slow rollout to FB so I haven't sent a PR.
Docs:
Actual code where we say we're ignore the method, but then returnf alse.
The text was updated successfully, but these errors were encountered: