-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSS builds fail after annotation bundling change #627
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
Nov 13, 2024
Summary: Fix the following error reported in #627: ``` $ cmake --build build_ [0/2] Re-checking globbed directories... [2/195] Linking CXX executable bin/thrift1 FAILED: bin/thrift1 : && /usr/bin/c++ -march=native -mtune=native -rdynamic thrift/compiler/CMakeFiles/thrift1.dir/main.cc.o thrift/compiler/CMakeFiles/thrift1.dir/compiler.cc.o -o bin/thrift1 -Wl,-rpath,:::::::::::::: lib/libcompiler_ast.a lib/libcompiler_lib.a -Wl,--whole-archive lib/libcompiler_generators.a -Wl,--no-whole-archive lib/libcompiler_lib.a lib/libcompiler.a lib/libcompiler_ast.a -lssl -lcrypto lib/libmustache.a lib/libwhisker.a lib/libcompiler_base.a /usr/lib64/libfmt.so.9.1.0 && : /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: thrift/compiler/CMakeFiles/thrift1.dir/compiler.cc.o: in function `apache::thrift::compiler::(anonymous namespace)::parse_and_mutate(apache::thrift::compiler::source_manager&, apache::thrift::compiler::sema_context&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, apache::thrift::compiler::parsing_params const&, apache::thrift::compiler::(anonymous namespace)::gen_params const&)': compiler.cc:(.text+0x306f): undefined reference to `apache::thrift::detail::bundled_annotations::scope_file_content()' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. ``` Reviewed By: yoney Differential Revision: D65833136 fbshipit-source-id: 0d5bd826b073a1e0cdab81016f792a8f49d2240e
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this issue
Nov 13, 2024
Summary: Fix the following error reported in facebook/fbthrift#627: ``` $ cmake --build build_ [0/2] Re-checking globbed directories... [2/195] Linking CXX executable bin/thrift1 FAILED: bin/thrift1 : && /usr/bin/c++ -march=native -mtune=native -rdynamic thrift/compiler/CMakeFiles/thrift1.dir/main.cc.o thrift/compiler/CMakeFiles/thrift1.dir/compiler.cc.o -o bin/thrift1 -Wl,-rpath,:::::::::::::: lib/libcompiler_ast.a lib/libcompiler_lib.a -Wl,--whole-archive lib/libcompiler_generators.a -Wl,--no-whole-archive lib/libcompiler_lib.a lib/libcompiler.a lib/libcompiler_ast.a -lssl -lcrypto lib/libmustache.a lib/libwhisker.a lib/libcompiler_base.a /usr/lib64/libfmt.so.9.1.0 && : /usr/lib/gcc/x86_64-pc-linux-gnu/14/../../../../x86_64-pc-linux-gnu/bin/ld: thrift/compiler/CMakeFiles/thrift1.dir/compiler.cc.o: in function `apache::thrift::compiler::(anonymous namespace)::parse_and_mutate(apache::thrift::compiler::source_manager&, apache::thrift::compiler::sema_context&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, apache::thrift::compiler::parsing_params const&, apache::thrift::compiler::(anonymous namespace)::gen_params const&)': compiler.cc:(.text+0x306f): undefined reference to `apache::thrift::detail::bundled_annotations::scope_file_content()' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. ``` Reviewed By: yoney Differential Revision: D65833136 fbshipit-source-id: 0d5bd826b073a1e0cdab81016f792a8f49d2240e
Should be fixed by 94d5675. Could you confirm? |
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this issue
Nov 13, 2024
Summary: Update the stable commits to include fix for facebook/fbthrift#627 - facebook/fbthrift@94d5675. Reviewed By: srikrishnagopu Differential Revision: D65889568 fbshipit-source-id: d6119e540dd41f87cdc27a85291d1dcc3db941be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starting with 1f3fec4, builds now fail with:
I suspect this is due to the
scope_file_content
call being moved out of the#ifndef THRIFT_OSS
block.The text was updated successfully, but these errors were encountered: