Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] - Add set -e by default for inline #210

Closed
l50 opened this issue Aug 1, 2023 · 2 comments
Closed

[REQUEST] - Add set -e by default for inline #210

l50 opened this issue Aug 1, 2023 · 2 comments
Assignees
@inesusvet @d3sch41n
Labels
enhancement New feature or request

Comments

@l50
Copy link
Contributor

l50 commented Aug 1, 2023

What happened?

All inline TTPs will have set -e by default. If a user wants to not run a step with that, they can add set +e to their TTP.

Any suggestions for fixing this bug?

No response

Relevant log output

No response

Details about your environment

No response
@l50 l50 added the bug Something isn't working label Aug 1, 2023
@d3sch41n d3sch41n changed the title 🚨 [BUG] - Add set -e by default for inline 🚨 [REQUEST] - Add set -e by default for inline Sep 26, 2023
@d3sch41n d3sch41n self-assigned this Sep 26, 2023
@d3sch41n
Copy link
Contributor

Working on this in current sprint

@d3sch41n d3sch41n added enhancement New feature or request and removed bug Something isn't working labels Sep 26, 2023
@d3sch41n d3sch41n changed the title 🚨 [REQUEST] - Add set -e by default for inline [REQUEST] - Add set -e by default for inline Sep 26, 2023
@inesusvet inesusvet mentioned this issue Nov 2, 2023
Closed
inesusvet added a commit to inesusvet/TTPForge that referenced this issue Nov 2, 2023
@inesusvet @facebook-github-bot
Bash executor should not tolerate non-zero exit codes by default
3cce2d9 
Summary:
From github issue facebookincubator#210
facebookincubator#210

> All inline TTPs will have set -e by default. If a user wants to not run a step with that, they can add set +e to their TTP.

Differential Revision: D50892103
@inesusvet inesusvet self-assigned this Nov 2, 2023
facebook-github-bot pushed a commit that referenced this issue Nov 6, 2023
@inesusvet @facebook-github-bot
Bash executor should not tolerate non-zero exit codes by default (#406)
486ec6a 
Summary:
Pull Request resolved: #406

From github issue #210
#210

> All inline TTPs will have set -e by default. If a user wants to not run a step with that, they can add set +e to their TTP.

Reviewed By: nicolagiacchetta, d3sch41n

Differential Revision: D50892103

fbshipit-source-id: fbaee2bbc51fbdeb1c9bf474f53aecf02c62640d
@inesusvet
Copy link
Contributor

Resolved by #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inesusvet inesusvet

@d3sch41n d3sch41n

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@inesusvet @l50 @d3sch41n