diff --git a/.github/workflows/_build_wheels.yaml b/.github/workflows/_build_wheels.yaml index 2fe347f20..6ee6e3b83 100644 --- a/.github/workflows/_build_wheels.yaml +++ b/.github/workflows/_build_wheels.yaml @@ -19,6 +19,7 @@ jobs: name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, linux-x86_64, ${{ matrix.variant }}, ${{ matrix.sanitizers }}) uses: ./.github/workflows/_build_wheel-linux.yaml strategy: + fail-fast: false matrix: torch: ['1.12.1'] py: ['3.8', '3.9', '3.10'] @@ -35,6 +36,7 @@ jobs: name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, linux-x86_64, ${{ matrix.variant }}, ${{ matrix.sanitizers }}) uses: ./.github/workflows/_build_wheel-linux.yaml strategy: + fail-fast: false matrix: torch: ['1.13.1'] py: ['3.8', '3.9', '3.10'] @@ -51,6 +53,7 @@ jobs: name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, linux-x86_64, ${{ matrix.variant }}, ${{ matrix.sanitizers }}) uses: ./.github/workflows/_build_wheel-linux.yaml strategy: + fail-fast: false matrix: torch: ['2.0.1'] py: ['3.8', '3.9', '3.10', '3.11'] @@ -58,16 +61,20 @@ jobs: sanitizers: ['nosan'] include: - run_integration_tests: false + + # Integration Tests - torch: '2.0.1' py: '3.11' variant: 'cpu' - sanitizers: 'asan_ubsan' - run_integration_tests: false + sanitizers: 'nosan' + run_integration_tests: true + + # ASAN/UBSAN - torch: '2.0.1' py: '3.11' variant: 'cpu' - sanitizers: 'nosan' - run_integration_tests: true + sanitizers: 'asan_ubsan' + run_integration_tests: false with: torch: ${{ matrix.torch }} py: ${{ matrix.py }} @@ -81,6 +88,7 @@ jobs: uses: ./.github/workflows/_build_wheel-linux.yaml if: inputs.release_type == 'stable' strategy: + fail-fast: false matrix: torch: ['2.0.1'] py: ['3.8', '3.9', '3.10', '3.11'] @@ -98,6 +106,7 @@ jobs: # uses: ./.github/workflows/_build_wheel-macos.yaml # if: inputs.release_type == 'stable' # strategy: +# fail-fast: false # matrix: # torch: ['2.0.1'] # py: ['3.8', '3.9', '3.10', '3.11'] diff --git a/.github/workflows/_lint_cc.yaml b/.github/workflows/_lint_cc.yaml index 8bfd900f7..84d3fee38 100644 --- a/.github/workflows/_lint_cc.yaml +++ b/.github/workflows/_lint_cc.yaml @@ -6,10 +6,13 @@ on: workflow_call: - -env: - TORCH: '2.0.1' - PY: '3.11' + inputs: + torch: + type: string + default: '2.0.1' + py: + type: string + default: '3.11' defaults: run: @@ -32,12 +35,12 @@ jobs: yum --assumeyes install libsndfile-devel - name: Create the Python virtual environment run: | - python$PY -m venv ~/venv + python${{ inputs.py }} -m venv ~/venv echo ~/venv/bin >> "$GITHUB_PATH" - name: Install PyTorch run: | - pip install torch==$TORCH\ + pip install torch==$${{ inputs.torch }}\ --extra-index-url https://download.pytorch.org/whl/cu118 - name: Install build requirements for fairseq2n run: | diff --git a/.github/workflows/_lint_py.yaml b/.github/workflows/_lint_py.yaml index ff69ecc4d..62a4e19a8 100644 --- a/.github/workflows/_lint_py.yaml +++ b/.github/workflows/_lint_py.yaml @@ -6,10 +6,13 @@ on: workflow_call: - -env: - TORCH: '2.0.1' - PY: '3.11' + inputs: + torch: + type: string + default: '2.0.1' + py: + type: string + default: '3.11' defaults: run: @@ -29,12 +32,12 @@ jobs: yum --assumeyes install libsndfile-devel - name: Create the Python virtual environment run: | - python$PY -m venv ~/venv + python${{ inputs.py }} -m venv ~/venv echo ~/venv/bin >> "$GITHUB_PATH" - name: Install PyTorch run: | - pip install torch==$TORCH\ + pip install torch==${{ inputs.torch }}\ --extra-index-url https://download.pytorch.org/whl/cpu - name: Install linters run: | diff --git a/.github/workflows/_lint_sh.yaml b/.github/workflows/_lint_sh.yaml index 3a984743a..e2b974e9b 100644 --- a/.github/workflows/_lint_sh.yaml +++ b/.github/workflows/_lint_sh.yaml @@ -6,9 +6,10 @@ on: workflow_call: - -env: - PY: '3.11' + inputs: + py: + type: string + default: '3.11' defaults: run: @@ -28,7 +29,7 @@ jobs: yum --assumeyes install libsndfile-devel - name: Create the Python virtual environment run: | - python$PY -m venv ~/venv + python${{ inputs.py }} -m venv ~/venv echo ~/venv/bin >> "$GITHUB_PATH" - name: Install shellcheck diff --git a/.github/workflows/ci_build_wheels.yaml b/.github/workflows/ci_build_wheels.yaml index 3da66942f..e6d6739d4 100644 --- a/.github/workflows/ci_build_wheels.yaml +++ b/.github/workflows/ci_build_wheels.yaml @@ -14,26 +14,11 @@ on: - 'doc/**' jobs: - build_pt112_wheel-linux: - name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, linux-x86_64, ${{ matrix.variant }}, ${{ matrix.sanitizers }}) - uses: ./.github/workflows/_build_wheel-linux.yaml - strategy: - matrix: - include: - - torch: '1.12.1' - py: '3.8' - variant: 'cpu' - sanitizers: 'nosan' - with: - torch: ${{ matrix.torch }} - py: ${{ matrix.py }} - variant: ${{ matrix.variant }} - sanitizers: ${{ matrix.sanitizers }} - - build_pt20_wheel-linux: + build_wheel-linux: name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, linux-x86_64, ${{ matrix.variant }}, ${{ matrix.sanitizers }}) uses: ./.github/workflows/_build_wheel-linux.yaml strategy: + fail-fast: false matrix: torch: ['2.0.1'] py: ['3.11'] @@ -41,16 +26,27 @@ jobs: sanitizers: ['nosan'] include: - run_integration_tests: false + + # Integration Tests - torch: '2.0.1' py: '3.11' variant: 'cpu' - sanitizers: 'asan_ubsan' - run_integration_tests: false + sanitizers: 'nosan' + run_integration_tests: true + + # ASAN/UBSAN - torch: '2.0.1' py: '3.11' variant: 'cpu' + sanitizers: 'asan_ubsan' + run_integration_tests: false + + # Lowest Supported Version + - torch: '1.12.1' + py: '3.8' + variant: 'cpu' sanitizers: 'nosan' - run_integration_tests: true + run_integration_tests: false with: torch: ${{ matrix.torch }} py: ${{ matrix.py }} @@ -58,26 +54,19 @@ jobs: sanitizers: ${{ matrix.sanitizers }} run_integration_tests: ${{ matrix.run_integration_tests }} - build_pt121_wheel-macos: - name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, macos-x86_64) - uses: ./.github/workflows/_build_wheel-macos.yaml - strategy: - matrix: - include: - - torch: '1.12.1' - py: '3.8' - with: - torch: ${{ matrix.torch }} - py: ${{ matrix.py }} - - build_pt20_wheel-macos: + build_wheel-macos: name: Build wheels (pt${{ matrix.torch }}, py${{ matrix.py }}, macos-x86_64) uses: ./.github/workflows/_build_wheel-macos.yaml strategy: + fail-fast: false matrix: include: - torch: '2.0.1' py: '3.11' + + # Lowest Supported Version + - torch: '1.12.1' + py: '3.8' with: torch: ${{ matrix.torch }} py: ${{ matrix.py }}