Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record trajectories in super (Skill) class for both base & arm #137

Open
KavitShah1998 opened this issue Feb 9, 2024 · 0 comments
Open

Comments

@KavitShah1998
Copy link
Contributor

KavitShah1998 commented Feb 9, 2024

As suggested by @akshararai in PR##131 -> #131 (comment)

Currently:
Nav skill returns trajectory.
Pick skill returns a dict.

self.gaze_result = {
            "target_object": target_object,
            "time_taken": time.time() - self.start_time,
            "success": self.env.grasp_attempted and success_status_from_user_feedback,
        }

Place skill returns a dict

self.place_result = {
            "time_taken": time.time() - self.start_time,
            "success": is_position_within_bounds(
                local_place_target_spot,
                local_ee_pose_spot,
                self.config.SUCC_XY_DIST,
                self.config.SUCC_Z_DIST,
                convention="spot",
            ),
            "place_target": local_place_target_spot,
            "ee_pos": local_ee_pose_spot,
        }

we should standardize what they all return when we move to an abstract class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant