ToolBarFlowPane does not wrap anymore in v11.1.4

[dedeibel]

It seems like ToolBarFlowPane does not wrap plugin icons anymore if the space becomes to small. At some point the height increases but the icons remain in the first row.

It works if I remove the changed line 82 form adjustToolBarWidth in ToolBarFlowPane.java.

this.setWidth(length);

[RalphSteinhagen]

@dedeibel It seems to be a JavaFX layout bug of FlowPane in a combination of being embedded in a StackPane. Removing the setWidth(length) made it worse as the toolbar unnecessarily maximized to the full chart width.

Added a workaround of forcing specific width, height and preferred wrapping width.
Not ideal... but should do for now. Will re-check once we move to a newer JavaFX version.

Fix is now in the PR #164 and will be merged as soon as it is cross-checked.

[RalphSteinhagen]

@dedeibel is your problem solved with this patch?

[dedeibel]

@RalphSteinhagen unfortunately there seems to be a problem at some point of the wrapping – some elements are wrapped before the second line is established.

Not sure how critical this is but it also seems new to me.

[RalphSteinhagen]

Hi @dedeibel, as mentioned above this seems to be a JavaFX feature: FlowPane inside StackPane (via JavaFX/ControlsFX Skin) that does not allow automatically managing the size of its children.

The commit a94e115 is merely workaround for one of the symptoms but leaves the known -- albeit less likely -- side-effect you also mentioned.

Unfortunately, I do not see any easy option of fixing this from an FX-user perspective w/o substantially rewriting StackPane and/or the JavaFX Skinning feature infrastructure.