-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4pt, 0pt] Staging settings with a commit token #174
Comments
Hi @drslebedev , Ralph on fair-acc/opendigitizer#212 mentioned that I should coordinated with you about that task, is it something I should wait for you to finish? Or is there something I could start working on? I guess the gui part could be started |
Hi @dantti , most of the issues are already implemented and merged. The only missing part is adding stored settings via Message port. But you can start working on UI. |
UI wise it's mostly done https://github.com/fair-acc/opendigitizer/tree/dantti/blocks_context it seems we need BlockControlsPanelContext changed to have a map<string, DigitizerUi::Block*> ? |
Thank you very much for your commit! Is there anything else you need from our side to complete the issue and submit a PR? |
We propose extending the Message API to support updated
Our goal is to minimize the API surface. For example, if the UI needs to retrieve all stored settings for each context, it can do so by first getting the list of available contexts and then fetching the settings for each context individually. |
Right now the multiplexed settings only have a single storage of all the active settings.
As detailed in #99 (review), a new "staging" API could allow staging settings with a commit token (e.g. a
std::string
) such that they are first stored in a background "staging" collection, instead of in the active settings collection.Then later on, the staged settings can be transported to the actually active collection of the
ctx_settings
via multiple ways:tag_t
on one of the streaming portspmt_t
message on one of the message portsSome things to consider:
The text was updated successfully, but these errors were encountered: