Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt,7pt] graph-prototype: Port and simplify picoscope implementations #113

Closed
frankosterfeld opened this issue Dec 1, 2022 · 2 comments · Fixed by #147
Closed

[5pt,7pt] graph-prototype: Port and simplify picoscope implementations #113

frankosterfeld opened this issue Dec 1, 2022 · 2 comments · Fixed by #147
Assignees

Comments

@frankosterfeld
Copy link

frankosterfeld commented Dec 1, 2022

The implementations for the different picoscope devices (3000a, 4000a, 5000, 6000) contain a lot of duplicated logic, only differing in the driver functions they call and the enums etc. they use. Check what of that can be simplified easily, where the differences are accidental and where they actually stem from different device functionality.

@frankosterfeld frankosterfeld changed the title Simplify picoscope implementations dev-4.0: Simplify picoscope implementations Dec 2, 2022
RalphSteinhagen pushed a commit that referenced this issue Dec 2, 2022
* Port of gr-digitizer to GNU Radio 4.0

Make code compile with GR 4.0, latest ROOT and latest Picoscope drivers. Some tests don't pass atm.

open issues/improvements to be followed-up later:
#110
#111
#112
#113 
#114 
#115 
#116 

Co-authored-by: Alexander Krimm <[email protected]>
@RalphSteinhagen RalphSteinhagen changed the title dev-4.0: Simplify picoscope implementations [] graph-prototype: Simplify picoscope implementations Jul 15, 2023
@RalphSteinhagen RalphSteinhagen changed the title [] graph-prototype: Simplify picoscope implementations [1pt] graph-prototype: Simplify picoscope implementations Jul 21, 2023
@RalphSteinhagen
Copy link
Member

meeting minutes:
main focus: stress commonality and modularise the differences between PS3000, PS4000, PS4000, PS6000

development against graph-prototype
new branch in gr-digitizer

Linked to #116

@RalphSteinhagen RalphSteinhagen changed the title [1pt] graph-prototype: Simplify picoscope implementations [5pt] graph-prototype: Port and simplify picoscope implementations Jul 21, 2023
@vimpostor
Copy link

vimpostor commented May 8, 2024

Some useful bullet points from Matrix:

  • Rationalise the existing implementation to also support PS[3000,4000,5000,6000] digitizer. There is a build/header-include component but also abstraction since all these models are very similar but not identical,
    we should check the integration of the meta-tag information via the incoming MsgPortIn onto the detected trigger (for testing we assume that there is some trigger edge and the MsgInPort supplied with some test meta-tags that not necessarily are derived from a timing source block) , and
    rationalise the output types to:
    • std::int16_t: the raw output of each digitizer channel w/o further pre-processing but with trigger tags and some meta information (e.g. signal_name, rate, etc.)
    • float: the physical gain-scaled output with tags and full meta-info (i.e. and signal name, quantity, unit, min, max, etc.)
    • gr::UncertainValue<float>: containing the above plus the estimated measurement error -- the new UncertainValue<> wasn't available yet with the initial implementation but we should simplify and use this from now on.

@vimpostor vimpostor self-assigned this May 13, 2024
vimpostor added a commit that referenced this issue Jun 12, 2024
This allows the Block to be extended with support for various Picoscope
models.

Furthermore, this ports the custom work implementation to processBulk()
and implements the inclusion of timing messages received over the
message port.

Fixes #113
@vimpostor vimpostor linked a pull request Jun 12, 2024 that will close this issue
vimpostor added a commit that referenced this issue Jun 13, 2024
This allows the Block to be extended with support for various Picoscope
models.

Furthermore, this ports the custom work implementation to processBulk()
and implements the inclusion of timing messages received over the
message port.

Fixes #113

Signed-off-by: Magnus Groß <[email protected]>
@vimpostor vimpostor changed the title [5pt] graph-prototype: Port and simplify picoscope implementations [5pt,7pt] graph-prototype: Port and simplify picoscope implementations Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA-Accepted/Merged (∞)
Development

Successfully merging a pull request may close this issue.

3 participants