Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demux_ff - Add error into data-stream if triggers are to tight together / overlap #71

Open
alexxcons opened this issue Sep 15, 2021 · 2 comments

Comments

@alexxcons
Copy link
Collaborator

In GitLab by @alexxcons on Mar 19, 2021, 09:39

See "TODO" line in demux_ff_impl.cc

Instead of just breaking, an additional check should be done for each each found trigger, in order to control if the distance between triggers is fine.

If triggers are too tight together, a Warning should be logged and the status entry of the related trigger-tag should have a flag to signal the problem to Fesa.

@alexxcons
Copy link
Collaborator Author

In GitLab by @alexxcons on Mar 19, 2021, 09:41

changed title from Demux_ff - Add error into data-stream if triggers are to tight together to Demux_ff - Add error into data-stream if triggers are to tight together{+ / overlap+}

@alexxcons
Copy link
Collaborator Author

alexxcons commented Sep 15, 2021

In GitLab by @alexxcons on Mar 19, 2021, 10:12

Edit: This comment is of no relevance. The following is only true for gr-digitizer Version 4.x. Starting with 5.x the feature to support overlapping trigger-windows was removed due to performance problems (See 0a5913d)

On fel0051 (SIS18 Timing, ), GSCD029:TIMING:Triggered@10kHz ... on EVT_COMMAND und CMD_SEQ_START always both trigger pulses can be seen. (1e6 trigger samples, 10MS/s, )

demux_ff can actually generate overlapping trigger windows in gr-digitizer 4.x, but not any more with v 5.x. To be checked if the scope itself can generate overlapping trigger-windows.

In any case, it looks like something goes wrong, when to many trigger-windows are meassured, so we at least should inform FESA via status flag in the tag.

Bildschirmfoto_2021-03-19_10-07-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant