Latest version generates invalid email addresses

[Bertg]

Describe the bug

When letting faker generate email addresses based on names, it now generates invalid email addresses, where older versions did not.

Example:

# Faker 3.4.1
Faker::Internet.unique.email(name: " Msgr. Titus Harvey")
# => "[email protected]"

The email is invalid as two sequential dots appear.

# Faker 3.3.1
Faker::Internet.unique.email(name: " Msgr. Titus Harvey")
# => "[email protected]"

To Reproduce

See code samples above

Expected behavior

Factory should keep generating valid email addresses, as a major escape is to populate databases with valid looking data.

Additional context

None

[Naraveni]

def username(specifier: nil, separators: %w[. _]) with_locale(:en) do case specifier when ::String names = specifier&.gsub("'", '')&.split shuffled_names = shuffle(names) return shuffled_names.join(sample(separators)).downcase

I checked the code and it seems they are using '_' and '.' as default separators. They are splitting the string using spaces which will result in your case [" Msgr.", "Titus","Harvey"]. 'Msgr.' might have been concatinated to other word in the list using '.' as separator which leaded to the result in your case.

Try without including '.' in the name.

If developers want I can work on this to ignore '.'.

[thdaraujo]

Hi @Bertg, try generating with a name that doesn't have an abbreviated title and it should work as you would expect:

> Faker::Internet.unique.email(name: "Titus Harvey")
=> "[email protected]"

[butsjoh]

@Bertg is my colleague and he is not showing the full example.

See below:

Faker::Internet.unique.email(name: Faker::Name.unique.name ) 

The problem is that in 3.3.1 the . was already being filtered out and all of a sudden in 3.4.1 it does not do that anymore. This is a serious regression from our view. Faker::Name.unique.name is not under our control ...

[butsjoh]

Just another example

In 3.4.1

irb(main):002> 100000.times.map.select { Faker::Internet.unique.email(name: Faker::Name.unique.name ).include?("..") }.count
=> 6754

In 3.3.1

irb(main):001> 100000.times.map.select { Faker::Internet.unique.email(name: Faker::Name.unique.name ).include?("..") }.count
=> 0

[Bertg]

@thdaraujo Respectfully, that remark is a bit besides the point.

In the previous versions of Faker I could use any name I want in Faker::Internet.unique.email(name: some_name) and a valid email would be returned. In the latest version, I can no longer as the Faker behaviour changed.

As my colleague pointed out this should be considered a regression. Clearly by only using Faker I can now generate a bunch of invalid email addresses, where before we could not.

[thdaraujo]

I see what you mean now. Please take a look at #2970 and check if it fixes the problem for you.

We can't guarantee that any of these emails will be valid though, but it should restore the previous behaviour.

By the way, you can also use the generator directly, without having to generate a name first:

Faker::Internet.unique.email