From 016687d6ff665f8bb5b22c62ca863e79214e7024 Mon Sep 17 00:00:00 2001 From: fynsta <63241108+fynsta@users.noreply.github.com> Date: Tue, 11 Jun 2024 12:40:28 +0200 Subject: [PATCH 1/2] Fix typo --- doc/default/vehicle.md | 2 +- lib/faker/default/vehicle.rb | 7 ++++--- lib/locales/en/vehicle.yml | 2 +- test/faker/default/test_faker_vehicle.rb | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/doc/default/vehicle.md b/doc/default/vehicle.md index 84944104bd..1f58668e1e 100644 --- a/doc/default/vehicle.md +++ b/doc/default/vehicle.md @@ -6,7 +6,7 @@ Available since version 1.6.4. Faker::Vehicle.vin #=> "LLDWXZLG77VK2LUUF" # Random vehicle manufacturer -Faker::Vehicle.manufacture #=> "Lamborghini" +Faker::Vehicle.manufacturer #=> "Lamborghini" Faker::Vehicle.make #=> "Honda" diff --git a/lib/faker/default/vehicle.rb b/lib/faker/default/vehicle.rb index e574db7434..0f8fc5dce1 100644 --- a/lib/faker/default/vehicle.rb +++ b/lib/faker/default/vehicle.rb @@ -48,12 +48,13 @@ def vin # @return [String] # # @example - # Faker::Vehicle.manufacture #=> "Lamborghini" + # Faker::Vehicle.manufacturer #=> "Lamborghini" # # @faker.version 1.6.4 - def manufacture - fetch('vehicle.manufacture') + def manufacturer + fetch('vehicle.manufacturer') end + alias_method :manufacture, :manufacturer ## # Produces a random vehicle make. diff --git a/lib/locales/en/vehicle.yml b/lib/locales/en/vehicle.yml index 320f1925ff..3f8d1f1834 100644 --- a/lib/locales/en/vehicle.yml +++ b/lib/locales/en/vehicle.yml @@ -1,7 +1,7 @@ en: faker: vehicle: - manufacture: + manufacturer: - Abarth - Acura - Aixam diff --git a/test/faker/default/test_faker_vehicle.rb b/test/faker/default/test_faker_vehicle.rb index ea23209990..71a43943f4 100644 --- a/test/faker/default/test_faker_vehicle.rb +++ b/test/faker/default/test_faker_vehicle.rb @@ -20,8 +20,8 @@ def test_vin end end - def test_manufacture - assert_match WORD_MATCH, @tester.manufacture + def test_manufacturer + assert_match WORD_MATCH, @tester.manufacturer end def test_color From 2ced718c6b86d0257fdec3ccf978bf067dadeb2c Mon Sep 17 00:00:00 2001 From: fynsta <63241108+fynsta@users.noreply.github.com> Date: Wed, 19 Jun 2024 10:02:45 +0200 Subject: [PATCH 2/2] Fix rubocop --- lib/faker/default/vehicle.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/faker/default/vehicle.rb b/lib/faker/default/vehicle.rb index 0f8fc5dce1..3f02c4c4f5 100644 --- a/lib/faker/default/vehicle.rb +++ b/lib/faker/default/vehicle.rb @@ -54,7 +54,7 @@ def vin def manufacturer fetch('vehicle.manufacturer') end - alias_method :manufacture, :manufacturer + alias manufacture manufacturer ## # Produces a random vehicle make.