From df2debec48fa9c2a6b15f7f6f4069fde0e3eccc6 Mon Sep 17 00:00:00 2001 From: Vytautas Liuolia Date: Fri, 23 Aug 2024 12:03:13 +0200 Subject: [PATCH] chore(vendor): temporarily skip checks for vendored mimeparse (#2294) This a temporary measure while we are releasing a new version of python-mimeparse, and we haven't decided yet whether to keep vendoring or simply reimplement the related functionality. --- .github/workflows/tests.yaml | 5 ++++- tests/test_deps.py | 15 --------------- 2 files changed, 4 insertions(+), 16 deletions(-) delete mode 100644 tests/test_deps.py diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 42206d05d..078e5f59a 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -38,7 +38,10 @@ jobs: - "look" - "asgilook" - "ws_tutorial" - - "check_vendored" + # NOTE(vytas): Temporarily disabled while we are releasing a + # new version of python-mimeparse, and haven't decided yet whether + # to keep vendoring or reimplement. + # - "check_vendored" - "twine_check" - "daphne" - "hypercorn" diff --git a/tests/test_deps.py b/tests/test_deps.py deleted file mode 100644 index a747b2af7..000000000 --- a/tests/test_deps.py +++ /dev/null @@ -1,15 +0,0 @@ -from falcon.vendor import mimeparse - -# TODO(vytas): Remove this test since it makes little sense now that -# we have vendored python-mimeparse? - - -def test_deps_mimeparse_correct_package(): - """Ensure we are dealing with python-mimeparse, not mimeparse.""" - - tokens = mimeparse.mimeparse.__version__.split('.') - - # NOTE(kgriffs): python-mimeparse starts at version 1.5.2, - # whereas the mimeparse package is at version 0.1.4 at the time - # of this writing. - assert int(tokens[0]) > 0, 'Incorrect vendored dependency version detected'