TestClient methods are typed to return _ResultBase, but actually return Result

[davetapley]

All these methods are typed to return _ResultBase:

falcon/falcon/testing/client.py

Lines 1041 to 1046 in 4910dd7

	async def simulate_get(self, path='/', **kwargs) -> _ResultBase:
	"""Simulate a GET request to an ASGI application.
	(See also: :py:meth:`falcon.testing.simulate_get`)
	"""
	return await self.simulate_request('GET', path, **kwargs)

But actually returns Result here:

falcon/falcon/testing/client.py

Line 638 in 4910dd7

return Result(helpers.closed_wsgi_iterable(iterable), srmock.status, srmock.headers)

And Result defines the methods which are useful in testing:

falcon/falcon/testing/client.py

Lines 328 to 348 in 4910dd7

	@property
	def text(self) -> str:
	if self._text is None:
	if not self.content:
	self._text = ''
	else:
	if self.encoding is None:
	encoding = 'UTF-8'
	else:
	encoding = self.encoding
	self._text = self.content.decode(encoding)
	return self._text
	@property
	def json(self) -> Optional[Union[dict, list, str, int, float, bool]]:
	if not self.text:
	return None
	return json_module.loads(self.text)

---

But because it's typed _ResultBase I get e.g. Cannot access member "json" for type "_ResultBase",
even though the methods work 😬

I presume this is an oversight and not intentional?

[CaselIT]

That seems likely yes. PR to fix would be appreciated!

[davetapley]

Closing for reasons on: #2209 (comment)

[CaselIT]

it seems doable, with a lot more effort

[davetapley]

@CaselIT I agree! See #2210 😁