From 53a49eae72009cceb01d5b9623bd9647339f24dd Mon Sep 17 00:00:00 2001 From: Federico Di Pierro Date: Thu, 30 Nov 2023 10:42:07 +0100 Subject: [PATCH] cleanup(cmd): require kernelrelease and kernelversion in local command. Signed-off-by: Federico Di Pierro --- cmd/local.go | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/cmd/local.go b/cmd/local.go index 4d7d78e8..4835a15e 100644 --- a/cmd/local.go +++ b/cmd/local.go @@ -1,17 +1,14 @@ package cmd import ( - "bytes" "github.com/falcosecurity/driverkit/pkg/driverbuilder" "github.com/spf13/cobra" "github.com/spf13/pflag" "github.com/spf13/viper" - "golang.org/x/sys/unix" "log/slog" "os" "os/user" "runtime" - "strings" ) type localCmdOptions struct { @@ -55,8 +52,6 @@ func NewLocalCmd(rootCommand *RootCmd, rootOpts *RootOptions, rootFlags *pflag.F // Add root flags, but not the ones unneeded unusedFlagsSet := map[string]struct{}{ "architecture": {}, - "kernelrelease": {}, - "kernelversion": {}, "target": {}, "kernelurls": {}, "builderrepo": {}, @@ -87,19 +82,6 @@ func persistentPreRunFunc(rootCommand *RootCmd, rootOpts *RootOptions) func(c *c return func(c *cobra.Command, args []string) error { // Default values rootOpts.Target = "local" - u := unix.Utsname{} - if err := unix.Uname(&u); err != nil { - slog.Error("failed to retrieve default uname values", "err", err) - // this only affects logs! - rootOpts.KernelRelease = "1.0.0" - rootOpts.KernelVersion = "1" - } else { - rootOpts.KernelRelease = string(bytes.Trim(u.Release[:], "\x00")) - kv := string(bytes.Trim(u.Version[:], "\x00")) - kv = strings.Trim(kv, "#") - kv = strings.Split(kv, " ")[0] - rootOpts.KernelVersion = kv - } rootOpts.Architecture = runtime.GOARCH return rootCommand.c.PersistentPreRunE(c, args) }