-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRACKING] Expand existing webserver
to serve Prometheus /metrics
endpoint
#3131
Comments
/assign @sgaist As discussed hand-off to Samuel 🙏 |
@incertum: GitHub didn't allow me to assign the following users: sgaist. Note that only falcosecurity members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgaist can you assign yourself, the bot doesn't allow me to do it. Thanks! |
/milestone 0.38.0 CC @leogr |
The libs unit tests should give a clear idea of the Prometheus metrics strings you should expect. Here are a few examples of metrics outside of libs metrics that would need to be created in Falco.
They are also part of the libs unit tests. In addition re the Prometheus namespace + subsystem I would suggest the following:
The subsystem should match the output rules metrics naming conventions https://falco.org/docs/metrics/falco-metrics/ Finally, since we did this major libs metrics refactor it could be nice to also refactor the metrics output handling for falco since we are now expanding the scope with Prometheus. You will find a nice solution 😉 no doubt @sgaist ! |
Noted and starting :-) |
/assign @sgaist |
Expand existing
webserver
to serve Prometheus/metrics
endpoint.The initial Prometheus tracking ticket lives here: falcosecurity/cncf-green-review-testing#12.
Work Items:
libs
metrics refactor supporting text-based Prometheus exposition format refactor!(libsinsp): coherent metrics interfacemetrics_collector
class + text-based Prometheus exposition format support libs#1652 @incertumlibs
referencing the newlibs_metrics_collector
, defer any other refactors (read below) feat(metrics): sync libs metrics collector refactor #3129 @incertumwebserver
to serve Prometheus/metrics
endpoint. TODO @sgaiststats_writer::collector::collect
is no good anymore and we shall refactor it, also in anticipation to add yet another metrics category for rules counters. TODO @sgaistThe text was updated successfully, but these errors were encountered: