Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the engine_version_semver key when dealing with artifacts configuration #348

Closed
alacuku opened this issue Nov 13, 2023 · 2 comments · Fixed by #378
Closed

Use the engine_version_semver key when dealing with artifacts configuration #348

alacuku opened this issue Nov 13, 2023 · 2 comments · Fixed by #378
Assignees
Milestone

Comments

@alacuku
Copy link
Member

alacuku commented Nov 13, 2023

What would you like to be added:

The falcosecurity/falco#2899 PR introduces a new key in the /versions endpoint exposed by falcoctl. We need to use the new key instead of the engine_version key.

We also need to write extensive unit/integration tests to make sure that we do not break existing deployments of falco when upgrading the artifacts to newer versions.

@alacuku
Copy link
Member Author

alacuku commented Nov 13, 2023

/assign @alacuku

@loresuso
Copy link
Member

loresuso commented Jan 4, 2024

With the introduction of the new key in both Falco and new (to be released) packages, falcoctl was not modified, since it already could handle numeric and semver versions. The PR by @FedeDP adds a test on the specific way we always checked for requirements, and I believe it is enough on the unit test side.
If we want to do bigger integration tests, I am not sure we should do that in falcoctl since we want to test if we are not breaking Falco.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants