Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve args in bpf exit event #1343

Open
1 of 3 tasks
incertum opened this issue Sep 8, 2023 · 22 comments
Open
1 of 3 tasks

[Feature] Improve args in bpf exit event #1343

incertum opened this issue Sep 8, 2023 · 22 comments
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@incertum
Copy link
Contributor

incertum commented Sep 8, 2023

Based on a discussion between @Andreagit97 @darryk10 and myself a few ideas shared by Andrea to improve bpf syscall based alerting in falco rules:

  • add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event
  • introduce the BPF commands name, so use evt.arg.cmd == BPF_PROG_LOAD instead of evt.arg.cmd == 5 -> Update(driver): Introduce the BPF commands name #1545
  • expose also the name of the BPF prog injected (not easy at all) -> comment @incertum not sure how valuable it would be for detections, maybe not really needed at the moment.
@incertum incertum added the kind/feature New feature or request label Sep 8, 2023
@Andreagit97 Andreagit97 changed the title Ideas to improve rules around bpf syscall improve args in bpf exit event Sep 11, 2023
@Andreagit97
Copy link
Member

this is a duplicate of #1342 but it is more detailed, I will close mine :)

@Andreagit97 Andreagit97 added this to the TBD milestone Sep 11, 2023
@incertum
Copy link
Contributor Author

oh 🤦‍♀️ I should have maybe checked before opening this issue.

@incertum incertum changed the title improve args in bpf exit event [Feature] Improve args in bpf exit event Sep 11, 2023
@Andreagit97 Andreagit97 modified the milestones: TBD, 0.14.0 Sep 11, 2023
@Rohith-Raju
Copy link
Contributor

@Andreagit97 @incertum Would love to work on this!!

@incertum
Copy link
Contributor Author

Awesome, you have any additional questions? Else please feel free to go ahead :) Thanks!

@Rohith-Raju
Copy link
Contributor

I'm going to solve them one by one and will reach out if I get stuck 😄.

@incertum
Copy link
Contributor Author

incertum commented Oct 2, 2023

Great! Suggesting to focus on the first 2 items in one PR -> easy wins, add direct value to Falco rules in the next release.

The last one may need to be queued depending on prioritization, not a top priority feature.

@incertum
Copy link
Contributor Author

/milestone TBD

@incertum
Copy link
Contributor Author

/milestone 0.15.0

@poiana poiana modified the milestones: TBD, 0.15.0 Dec 18, 2023
@incertum incertum modified the milestones: 0.15.0, TBD Mar 7, 2024
@incertum
Copy link
Contributor Author

incertum commented Mar 7, 2024

Changed milestone to TBD since 2 items are still open and to be discussed. @Rohith-Raju are you still interested in exploring the other 2 items in the future? No immediate urgency.

@Rohith-Raju
Copy link
Contributor

@incertum Yes, I'd love to!!

@incertum
Copy link
Contributor Author

incertum commented Mar 7, 2024

Awesome @Rohith-Raju likely these items would be for the summer after Falco 0.38.0, but dev and PR review can happen any time before of course!

@Rohith-Raju
Copy link
Contributor

Sure!! I'll reach out to you if I need more info!!

@poiana
Copy link
Contributor

poiana commented Jun 5, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Sep 3, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Dec 2, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event

This could be solved with #2068

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Jan 2, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Andreagit97
Copy link
Member

could be partially solved by #1867, at least the first point

add the possibility to check the return value, possibly expose evt.arg.cmd also in the exit event to have all fields of interest in one event

@Andreagit97
Copy link
Member

/remove-lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants