Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toast when there's no panorama available for a location #428

Closed
wbazant opened this issue Jul 19, 2024 · 2 comments
Closed

toast when there's no panorama available for a location #428

wbazant opened this issue Jul 19, 2024 · 2 comments
Labels
bug Unexpected problems or unintended behavior

Comments

@wbazant
Copy link
Collaborator

wbazant commented Jul 19, 2024

Randomly found an example: https://beta.fallingfruit.org/locations/1756237/@32.331724099999974,-64.73249530000001,14z

Nothing happens on beta site but my refactored version on localhost logs this error:

Street View data not found for this location. MapsRequestError: STREETVIEW_GET_PANORAMA: ZERO_RESULTS: There are no panoramas found that match the search criteria.

We should toast it.
@wbazant wbazant mentioned this issue Jul 25, 2024
Merged
@ezwelty ezwelty added the bug Unexpected problems or unintended behavior label Aug 12, 2024
@ezwelty
Copy link
Collaborator

ezwelty commented Aug 16, 2024

@wbazant I believe this will be closed by #419 ?

@wbazant
Copy link
Collaborator Author

wbazant commented Sep 25, 2024

This is live and working as proposed.

@wbazant wbazant closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problems or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezwelty @wbazant