Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(desktop) Top ribbon Map route should depend on redux state #432

Closed
wbazant opened this issue Jul 27, 2024 · 1 comment · Fixed by #459
Closed

(desktop) Top ribbon Map route should depend on redux state #432

wbazant opened this issue Jul 27, 2024 · 1 comment · Fixed by #459
Labels
desktop Specific to desktop layout enhancement New feature request

Comments

@wbazant
Copy link
Collaborator

wbazant commented Jul 27, 2024

We should be able to e.g. navigate from /locations/new to /about and back. Restore map view and context of what is happening - e.g. viewing or editing the location.

In the #419 PR I added similar behaviour on mobile, so we can go to settings and back -see src/components/mobile/Tabs.js.

This will also enable #421 proposal to move settings into top ribbon.

@ezwelty ezwelty added desktop Specific to desktop layout enhancement New feature request labels Aug 12, 2024
@wbazant
Copy link
Collaborator Author

wbazant commented Aug 16, 2024

Not needed for #421 but would still be a small enhancement.

Note that we don't want to / don't need to put the view in e.g. the /about URL - just reconstructing the target route from redux states will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Specific to desktop layout enhancement New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants